Fix failing pre-commit hook fails on directories #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letmerecall
changed the title
letmerecall
deleted the
DEID-1376-pre-commit-hook-fails-on-directories
branch
letmerecall
added a commit
that referenced
this pull request
Feb 8, 2023
* Updated README to include blocked-list and restructured * Adding minor suggestion by Guy Co-authored-by: Guy Dumais <dumais.guy@gmail.com> * update the readme with the blocked-list details * update with new REST route * Update README.md Co-authored-by: koryf <101284003+koryf@users.noreply.github.com> * Update README.md Co-authored-by: koryf <101284003+koryf@users.noreply.github.com> * keeping the old REST path until 3.0 is released. * Update pii_dict format according to deid 3.0.0beta3 * Fix failing pre-commit hook fails on directories (#17) * Add test for get flagged lines * Skip PII flag check for directories --------- Co-authored-by: ketakipai <ketaki@private-ai.com> Co-authored-by: ketakipai <110412492+ketakipai@users.noreply.github.com> Co-authored-by: Guy Dumais <dumais.guy@gmail.com> Co-authored-by: Guy Dumais <guy@private-ai.com> Co-authored-by: koryf <101284003+koryf@users.noreply.github.com>
guyd
added a commit
that referenced
this pull request
Feb 24, 2023
* Updated README to include blocked-list and restructured * Adding minor suggestion by Guy Co-authored-by: Guy Dumais <dumais.guy@gmail.com> * update the readme with the blocked-list details * update with new REST route * Update README.md Co-authored-by: koryf <101284003+koryf@users.noreply.github.com> * Update README.md Co-authored-by: koryf <101284003+koryf@users.noreply.github.com> * keeping the old REST path until 3.0 is released. * Update pii_dict format according to deid 3.0.0beta3 * Fix failing pre-commit hook fails on directories (#17) * Add test for get flagged lines * Skip PII flag check for directories * DEID-1458 - fix parametrization of the hook and many other aspects (#21) * DEID-1458 - fix parametrization of the hook and many other aspects * Update tests/test_get_flagged_lines.py Co-authored-by: Girish Sharma <girishsharma001@gmail.com> * DEID-1458 - rename to a more general filename * DEID-1458 - add unidiff to parse the diff and extract the text to check * DEID-1458 - add missing dependency * DEID-1458 - output PII location as a clickable link in Visual Studio code * DEID-1458 - remove debugging code --------- Co-authored-by: Girish Sharma <girishsharma001@gmail.com> --------- Co-authored-by: ketakipai <ketaki@private-ai.com> Co-authored-by: ketakipai <110412492+ketakipai@users.noreply.github.com> Co-authored-by: koryf <101284003+koryf@users.noreply.github.com> Co-authored-by: letmerecall <girishsharma001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Why this PR?
When the change is in directory, pre-commit hook fails with error.
Adding a symlink in text/symlink raise this error:
The error is a result of checking the
PII_CHECKflag on changed files and dirs.Description
What is changed?
PII_CHECKflag check for directories.get_flagged_lines()How has this been tested?
Checklist