Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate iTX and tracing refactor #25285

Merged
merged 23 commits into from
Nov 5, 2024
Merged

feat: integrate iTX and tracing refactor #25285

merged 23 commits into from
Nov 5, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Sep 25, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/client/runtime/library.js 186.7 KB (0%)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 607.85 KB (+0.02% 🔺)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 162.47 KB (0%)
packages/client/runtime/edge-esm.js 162.2 KB (0%)
packages/client/runtime/wasm.js 121.28 KB (0%)
packages/client/runtime/index-browser.js 33.9 KB (0%)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.13 MB (0%)
packages/client/prisma-client-0.0.0.tgz 2.88 MB (-0.62% 🔽)
packages/cli/prisma-0.0.0.tgz 3.73 MB (+0.01% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 860.47 KB (-0.68% 🔽)
packages/bundle-size/da-workers-neon/output.tgz 939.94 KB (-0.7% 🔽)
packages/bundle-size/da-workers-pg/output.tgz 958.39 KB (-0.68% 🔽)
packages/bundle-size/da-workers-pg-worker/output.tgz 914.09 KB (-0.72% 🔽)
packages/bundle-size/da-workers-planetscale/output.tgz 874.73 KB (-0.84% 🔽)
packages/bundle-size/da-workers-d1/output.tgz 832.86 KB (-0.71% 🔽)

@aqrln aqrln force-pushed the integration/itx-refactor branch from 94877f4 to f886005 Compare September 26, 2024 13:30
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #25285 will improve performances by 26.43%

Comparing integration/itx-refactor (c8d12fb) with main (b7210d9)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main integration/itx-refactor Change
⚡ client generation 100 models with relations 7.6 s 6 s +26.43%

@socket-security Socket Security
Copy link

socket-security bot commented Sep 26, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@aqrln aqrln added this to the 5.21.0 milestone Sep 26, 2024
@aqrln aqrln mentioned this pull request Sep 27, 2024
Merged
@aqrln
Copy link
Member Author

aqrln commented Oct 2, 2024

ci test all

@aqrln aqrln force-pushed the integration/itx-refactor branch 4 times, most recently from 31dff3d to cbacf88 Compare October 10, 2024 17:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

🟢 All good, this PR is no longer uses custom engine.

@aqrln aqrln force-pushed the integration/itx-refactor branch from cbacf88 to 60120c6 Compare October 24, 2024 15:45
@aqrln aqrln modified the milestones: 5.21.0, 6.0.0 Nov 4, 2024
@aqrln aqrln force-pushed the integration/itx-refactor branch from 29f86d5 to da84d8f Compare November 4, 2024 12:16
@aqrln aqrln marked this pull request as ready for review November 4, 2024 14:35
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2024
@jkomyno
Copy link
Contributor

jkomyno commented Nov 5, 2024 •
edited
Loading

Watch out: some Binary Engine tests are failing on Studio.test.ts, most likely because the engineType = "binary" engine doesn't support the prismaSchemaFolder preview feature.

Please skip those tests in the engineType = "binary" case.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@aqrln aqrln force-pushed the integration/itx-refactor branch from 5805d4a to c8d12fb Compare November 5, 2024 12:07
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@antfu/ni@0.21.12 environment, filesystem, shell 0 465 kB antfu
npm/arg@5.0.2 None 0 13.7 kB leerobinson
npm/cli-truncate@2.1.0 None +2 20 kB sindresorhus
npm/env-paths@2.2.1 None 0 10.2 kB sindresorhus
npm/escape-string-regexp@4.0.0 None 0 3.79 kB sindresorhus
npm/find-up@5.0.0 Transitive: filesystem +5 43.7 kB sindresorhus
npm/indent-string@4.0.0 None 0 4.4 kB sindresorhus
npm/is-windows@1.0.2 None 0 7.96 kB jonschlinkert
npm/log-update@4.0.0 None +7 170 kB sindresorhus
npm/p-map@4.0.0 None +2 20.9 kB sindresorhus
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn
npm/source-map-support@0.5.21 filesystem +2 895 kB linusu

🚮 Removed packages: npm/esbuild@0.19.2

View full report↗︎

@aqrln aqrln modified the milestones: 6.0.0, 5.22.0 Nov 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@aqrln aqrln merged commit c64991b into main Nov 5, 2024
262 checks passed
@aqrln aqrln deleted the integration/itx-refactor branch November 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
5.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aqrln @jkomyno @laplab