I took a look through the commit history (all three of them 😅). I can't see any mention of any issues.

I also just noticed that we still have the following endpoint at the bottom of the lib file.

#[cfg(feature = "wasm_logger")]
#[wasm_bindgen]
pub fn enable_logs() {
    wasm_logger::init(wasm_logger::Config::default());
}

This feels somewhat clunky to me as that then requires language-tools (/ I guess any other consumer of this package) to first make a call to enable_logs. So if I want to test code actions I first have to update the codeActions in language-tools to also call this first? I'm not sure if that was the actual intent but it's marked as pub and wasm_bindgen so that's my assumption.

We have a call_once hook on the rest of the fmt-wasm api now so I think it makes more sense to remove this enable_logs function and just add the wasm_logger::init to this hook :) That way if it's already being built with the feature flag enabled, it's assumed that logs are wanted.

Make prisma-fmt logs to work with language server #1193

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions