Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate remote status-bar item #316

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Differentiate remote status-bar item #316

merged 3 commits into from
Jul 19, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 19, 2022

This is a follow-up to #268 and makes the tatusBarItem.remoteBackground light gray so it stands out against the rest of the status bar.

Before After
Screen Shot 2022-07-19 at 14 15 49 Screen Shot 2022-07-19 at 14 16 03

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: 50149a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

Colors changed
--- base/themes/dark-colorblind.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/dark-colorblind.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#30363d",
+    "statusBar.focusBorder": "#1f6feb80",
     "statusBar.noFolderBackground": "#0d1117",
-    "statusBar.debuggingBackground": "#a66900",
     "statusBar.debuggingForeground": "#f0f6fc",
-    "statusBarItem.prominentBackground": "#161b22",
-    "statusBarItem.remoteForeground": "#8b949e",
-    "statusBarItem.remoteBackground": "#0d1117",
+    "statusBar.debuggingBackground": "#a66900",
+    "statusBarItem.prominentBackground": "#6e768166",
+    "statusBarItem.remoteForeground": "#c9d1d9",
+    "statusBarItem.remoteBackground": "#30363d",
+    "statusBarItem.hoverBackground": "#c9d1d914",
+    "statusBarItem.activeBackground": "#c9d1d91f",
+    "statusBarItem.focusBorder": "#1f6feb",
     "editorGroupHeader.tabsBackground": "#010409",
--- base/themes/dark-default.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/dark-default.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#30363d",
+    "statusBar.focusBorder": "#1f6feb80",
     "statusBar.noFolderBackground": "#0d1117",
-    "statusBar.debuggingBackground": "#da3633",
     "statusBar.debuggingForeground": "#f0f6fc",
-    "statusBarItem.prominentBackground": "#161b22",
-    "statusBarItem.remoteForeground": "#8b949e",
-    "statusBarItem.remoteBackground": "#0d1117",
+    "statusBar.debuggingBackground": "#da3633",
+    "statusBarItem.prominentBackground": "#6e768166",
+    "statusBarItem.remoteForeground": "#c9d1d9",
+    "statusBarItem.remoteBackground": "#30363d",
+    "statusBarItem.hoverBackground": "#c9d1d914",
+    "statusBarItem.activeBackground": "#c9d1d91f",
+    "statusBarItem.focusBorder": "#1f6feb",
     "editorGroupHeader.tabsBackground": "#010409",
--- base/themes/dark-dimmed.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/dark-dimmed.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#444c56",
+    "statusBar.focusBorder": "#316dca80",
     "statusBar.noFolderBackground": "#22272e",
-    "statusBar.debuggingBackground": "#c93c37",
     "statusBar.debuggingForeground": "#cdd9e5",
-    "statusBarItem.prominentBackground": "#2d333b",
-    "statusBarItem.remoteForeground": "#768390",
-    "statusBarItem.remoteBackground": "#22272e",
+    "statusBar.debuggingBackground": "#c93c37",
+    "statusBarItem.prominentBackground": "#636e7b66",
+    "statusBarItem.remoteForeground": "#adbac7",
+    "statusBarItem.remoteBackground": "#444c56",
+    "statusBarItem.hoverBackground": "#adbac714",
+    "statusBarItem.activeBackground": "#adbac71f",
+    "statusBarItem.focusBorder": "#316dca",
     "editorGroupHeader.tabsBackground": "#1c2128",
--- base/themes/dark-high-contrast.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/dark-high-contrast.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#7a828e",
+    "statusBar.focusBorder": "#409eff80",
     "statusBar.noFolderBackground": "#0a0c10",
-    "statusBar.debuggingBackground": "#ff6a69",
     "statusBar.debuggingForeground": "#0a0c10",
-    "statusBarItem.prominentBackground": "#272b33",
+    "statusBar.debuggingBackground": "#ff6a69",
+    "statusBarItem.prominentBackground": "#9ea7b366",
     "statusBarItem.remoteForeground": "#f0f3f6",
-    "statusBarItem.remoteBackground": "#0a0c10",
+    "statusBarItem.remoteBackground": "#525964",
+    "statusBarItem.hoverBackground": "#f0f3f614",
+    "statusBarItem.activeBackground": "#f0f3f61f",
+    "statusBarItem.focusBorder": "#409eff",
     "editorGroupHeader.tabsBackground": "#010409",
--- base/themes/light-colorblind.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/light-colorblind.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#d0d7de",
+    "statusBar.focusBorder": "#0969da80",
     "statusBar.noFolderBackground": "#ffffff",
-    "statusBar.debuggingBackground": "#ac5e00",
     "statusBar.debuggingForeground": "#ffffff",
-    "statusBarItem.prominentBackground": "#f6f8fa",
-    "statusBarItem.remoteForeground": "#57606a",
-    "statusBarItem.remoteBackground": "#ffffff",
+    "statusBar.debuggingBackground": "#ac5e00",
+    "statusBarItem.prominentBackground": "#afb8c133",
+    "statusBarItem.remoteForeground": "#24292f",
+    "statusBarItem.remoteBackground": "#eaeef2",
+    "statusBarItem.hoverBackground": "#24292f14",
+    "statusBarItem.activeBackground": "#24292f1f",
+    "statusBarItem.focusBorder": "#0969da",
     "editorGroupHeader.tabsBackground": "#f6f8fa",
--- base/themes/light-default.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/light-default.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#d0d7de",
+    "statusBar.focusBorder": "#0969da80",
     "statusBar.noFolderBackground": "#ffffff",
-    "statusBar.debuggingBackground": "#cf222e",
     "statusBar.debuggingForeground": "#ffffff",
-    "statusBarItem.prominentBackground": "#f6f8fa",
-    "statusBarItem.remoteForeground": "#57606a",
-    "statusBarItem.remoteBackground": "#ffffff",
+    "statusBar.debuggingBackground": "#cf222e",
+    "statusBarItem.prominentBackground": "#afb8c133",
+    "statusBarItem.remoteForeground": "#24292f",
+    "statusBarItem.remoteBackground": "#eaeef2",
+    "statusBarItem.hoverBackground": "#24292f14",
+    "statusBarItem.activeBackground": "#24292f1f",
+    "statusBarItem.focusBorder": "#0969da",
     "editorGroupHeader.tabsBackground": "#f6f8fa",
--- base/themes/light-high-contrast.json	2022-07-19 05:29:28.339399612 +0000
+++ themes/light-high-contrast.json	2022-07-19 05:29:25.995389187 +0000
@@ -80,8 +80,12 @@
     "statusBar.border": "#30363d",
+    "statusBar.focusBorder": "#0349b480",
     "statusBar.noFolderBackground": "#ffffff",
-    "statusBar.debuggingBackground": "#a0111f",
     "statusBar.debuggingForeground": "#ffffff",
-    "statusBarItem.prominentBackground": "#e7ecf0",
+    "statusBar.debuggingBackground": "#a0111f",
+    "statusBarItem.prominentBackground": "#acb6c033",
     "statusBarItem.remoteForeground": "#24292f",
-    "statusBarItem.remoteBackground": "#ffffff",
+    "statusBarItem.remoteBackground": "#e7ecf0",
+    "statusBarItem.hoverBackground": "#24292f14",
+    "statusBarItem.activeBackground": "#24292f1f",
+    "statusBarItem.focusBorder": "#0349b4",
     "editorGroupHeader.tabsBackground": "#ffffff",

@simurai simurai merged commit d88b806 into main Jul 19, 2022
@simurai simurai deleted the remote-status-bar branch July 19, 2022 05:32
@primer-css primer-css mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant