Dark High Contrast theme + V2 colors #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simurai
changed the title
|
In case anyone wants to give this PR a try:
|
|
I found a bug that the updated file in the explore shows dark instead of green for the new 5.0.0 preview version. Stable version 4.2.1 has no issues. 5.0.0: 4.2.1: |
Thanks for testing. 🙇 Should be fixed by 7312381. |
simurai
changed the title
Merged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Dark High Contrasttheme. That matches the settings on github.com.@primer/primitivesand uses the V2 colors. Now that it's being enabled on github.com. There are probably quite a few regressions because in V2 a lot of variables are not available anymore and needed to be mapped to new variables.