Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub.com dimmed theme #138

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add GitHub.com dimmed theme #138

merged 2 commits into from
Mar 17, 2021

Conversation

dominicegginton
Copy link
Contributor

@dominicegginton dominicegginton commented Mar 16, 2021

I have opened this PR against the primer:github-com-themes branch that currently has an open PR (#132). Here I have added the new GitHub.com Dimmed dark theme that is currently being rolled out on GitHub.com and implemented the primer terminal colors that are included in the latest releases of primer/primitives.

Changes in this PR

  • Adds GitHub.com new dark dimmed theme
  • Updates the package-lock.json file to version 2
  • Adds terminal colors as suggested here & here

Screenshots

GitHub.com Web Dimmed Theme GitHub.com VSCode Dimmed theme
screenshot-Tue-16Mar21_20 21 screenshot-Tue-16Mar21_20 21_000

@dominicegginton dominicegginton changed the title Add github.com dimmed theme Add GitHub.com dimmed theme Mar 16, 2021
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Also thanks for adding the terminal colors. ✨

@simurai simurai merged commit 9a986ee into primer:github-com-themes Mar 17, 2021
@dominicegginton dominicegginton mentioned this pull request Mar 17, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants