@simurai Thank you for this PR, this feels like a really good solution

Awesome. Can't wait to have it merged!

Anything stopping this PR from being merged?

Anything stopping this PR from being merged?

I think we still have to decide if GitHub.com Dark is the right name moving forward. /cc @broccolini

If you already wanna try the github.com theme, you can go back to a previous version by clicking on the dropdown next to "Uninstall":

Then choose "Install Another Version..." and pick 2.0.1:

I think we still have to decide if GitHub.com Dark is the right name moving forward.

How about this?

• GitHub.com Light, GitHub Light -> GitHub Light (since they are almost the same)
• GitHub Dark -> GitHub Dark Classic
• GitHub.com Dark -> GitHub Dark

@simurai, just noticed that GitHub will be adding, a dimmed and deuteranomaly colorblind theme to GitHub.com. We should add these to the vscode theme extension to keep consistent. This could clear up some of the confusion that was caused when dark mode was released for this extension. Let me know if you need any help on this 😄

Suggestion

With the addition of the new GitHub.com dimmed theme recently merged into this PR (#138), I believe we can simplify theme names and remove the original themes reducing confusion and simplifying user experience. My suggestion is:

Remove

• GitHub Light: Due to high similarity to GitHub.com Light
• GitHub Dark: Due to high similarity to GitHub.com Dimmed

As you can see it is clear that the new old themes are extremely similar to the new .com themes. These old themes have been forked as discussed in #114 and the new dimmed theme addresses the main concern of contrast that resulted in the rollback of the new dark theme in the first place. Due to this, I believe it is not worth supporting the old thems moving forward.

GitHub Light	GitHub.com Light

GitHub Dark	GitHub.com Dimmed

Rename

• GitHub.com Light ➡️ GitHub Light
• GitHub.com Dark ➡️ GitHub Dark
• GitHub.com Dark Dimmed ➡️ GitHub Dimmed

If removing the original themes it makes sense to rename these removing the .com.

Result

This would leave us with these three themes that follow the new GitHub.com website:

GitHub Light	GitHub Dark	GitHub Dimmed

If anyone has any comments or feedback for this suggestion I'm making please let me know. If this is something people and @simurai want I'm happy to open a PR for review.

Update: With ea02865, the naming of the themes are:

• GitHub Light stays as is
• GitHub Dark stays as is
• GitHub Light Default ✨ new ✨
• GitHub Dark Default ✨ new ✨
• GitHub Dark Dimmed ✨ new ✨

I'm not a big fan of the word "Default" in the name, but it allows the old Light/Dark themes to stay and it matches how github.com calls the themes (with switched order):

@simurai with these changes can we see an update to the extension soon? I'd really like to turn auto updating for extensions back on. Every time update happens it updates this extension and I have to roll it back, so had to turn auto update off.

I didn't want to be "that" guy, but, come on, this PR has been open for more than 2 months, which is honestly quite ridiculous.
If naming is the concern, that can be decided and changed even after this gets released. Please merge this PR.
Thanks

@stagefright5 I know a lot of people (including me) are excited about the new official themes that will be added with this PR. But I'm sure the GitHub primer team are busy and want to make sure they have a clear and consistent direction to their design system. Remember this is also the default theme for GitHub Codespaces so is important to the GitHub brand image that it's of high standard.

If naming is the concern, that can be decided and changed even after this gets released.

We tried to rename it before, but I think VS Code uses the name as the identifier, so we can't really change names later without causing disruptions.

Remember this is also the default theme for GitHub Codespaces

Yep, this is not really a "stand-alone" theme and is part of GitHub's release cycles. So sometimes things can get postponed.

Regardless of how long it takes to release, thank you @simurai and everyone for your work. I've been a long time Dracula theme user, since Zeno released it, everywhere a theme for it exists I used it... GitHub's new dark theme is the first time I ever saw a theme that made me want to switch.

This looks awesome guys, great work! Looks like the PR is awaiting "final approval" - just wondering who needs to do that as I'm mega impatient to use dark dimmed! Looks like all the dev work has been done right?

nonameolsson approved these changes

Ok, in that case, let's merge it. 🚢