Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dark changes #123

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Revert dark changes #123

merged 3 commits into from
Jan 23, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 23, 2021

After the 2.0.0 release we got a lot of feedback asking to keep the old dark theme. This reverts all the changes #102 to the Dark theme (also some to Light) and should be the same as 1.1.5.

What about the dark theme from github.com?

We're still evaluating the best path forward. An option could be to release all the themes from github.com under a different name. For example GitHub.com Dark.

This reverts commit 3f3a872, reversing
changes made to e2fdb71.
This reverts commit c49673b, reversing
changes made to c4a98a6.
This reverts commit c4a98a6, reversing
changes made to 7e4192f.
@simurai simurai merged commit 4c4eb3d into master Jan 23, 2021
@simurai simurai deleted the revert-dark-changes branch January 23, 2021 07:20
@fi3ework
Copy link

fi3ework commented Jan 23, 2021

What about providing multiple dark themes? I prefer the new dark mode and I install a 2.0.1 version to downgrade from 3.0.

@Harry-Harrison
Copy link

I also liked the dark-dark version over the grey-dark one. It's the Github theme, it should "match" GitHub, no?

@ggirotto
Copy link

Guys, you probably received only the feedback from who didn't like the new dark theme, but haven't received from those that loved it, like me.

@julio-nf
Copy link

julio-nf commented Jan 23, 2021

At first I didn't like the new dark theme, but after a few hours I loved it. The colors of the text are much easier to see. Maybe launching on the same extension with another name like GitHub Dark+ or something like that would be great.

@alexmigf
Copy link

alexmigf commented Jan 23, 2021

I'm with you @julio-nf, initially was hard but now I want it back 😞

Getting back to 2.0.1, but a new theme in different name would be much appreciated.

@dominicegginton
Copy link
Contributor

I think we should release the offical GitHub.com dark and light theme along with a dimmed version (the old dark theme) all within this one extention. Personaly I like the new dark theme but can see why we need the option for the old dark theme too as it can be easier on the eyes.

@tri-nga
Copy link

tri-nga commented Jan 23, 2021

Imho the 2.0.1 dark version has a stronger identity than this revert. I've tried maybe every theme and color scheme out there and now I only have the default Dark+ and the 2.0.1 Github Theme.
I would very slightly dim the 2.0.1 version, to avoid too much contrast, or at very least meet in between the Old Dark and the "what would have been" the new dark.
Also this should be the same in github.com, for better UX.
edit: do this theme follow the Primer color's system ?

@joshmanders
Copy link

I don't see why caving to complainers, the whole point of this theme is to be GitHub themed, the new dark theme is GitHub's OFFICIAL dark theme, not an alternative created based off the official white theme to satisfy people. IMO the old dark theme should be split out or made as an alternative in this one.

Those people who don't like the new official dark theme can fork v1.1.5 and maintain it themselves.

@0xAndrewBlack
Copy link

I agree with the ones who support the new change.
It should match the OFFICIAL GitHub site theme so I don't get why was it necessary to revert it.
I just noticed a few minutes ago on my work PC that the theme is synced but the old gray is showing not the new like on my main PC after checking out the repo and seeing this nonsense.
But to fit every need there should be a fork or multiple options to choose from imo.

@Harry-Harrison
Copy link

I think we should release the offical GitHub.com dark and light theme along with a dimmed version (the old dark theme) all within this one extention. Personaly I like the new dark theme but can see why we need the option for the old dark theme too as it can be easier on the eyes.

This makes the most sense I think. Would mean that there's one GitHub theme package with a higher install count and shared updates instead of maintaining multiple repos with fixes and things.

@HazemAM
Copy link

HazemAM commented Jan 24, 2021

I also think the grey one should be listed in the same extension under a different name, e.g. "GitHub Dark (legacy)" or something similar. I like the newer one more, but I totally understand why the decision was reverted.

For now I'm going to use version 2.0.1 of the extension through VS Code's "Install another version..." option.

@leepowelldev
Copy link

Like others initially I thought the new darker theme was too much, but after a few hours I really liked it. Now the previous dark theme looks a bit washed out. I'd also suggest releasing the old/current dark version under a new theme name is the best way forward and keep this in sync with the official Github colour palette.

@fxn
Copy link

fxn commented Jan 24, 2021

Isn't the point of this theme to match GitHub? What some users think is irrelevant, the only thing that is relevant is that the theme matches GitHub today. If you do not like the theme in GitHub, just do not pick this extension.

@Gameghostify
Copy link

Reverting back to 2.0.1 as well, the update was awesome

@eunakria
Copy link

The new dark theme was great; it was a change from the previous one, but it massively aided with contrast and accessibility, and still kept the same great color scheme.

I think that reverting it was a little bit silly; change is inevitable, and the changes you guys made were productive, so why go back on them?

@simurai
Copy link
Contributor Author

simurai commented Jan 25, 2021

I think we should release the offical GitHub.com dark and light theme along with a dimmed version (the old dark theme) all within this one extention.

This is technically possible, yes. But the new themes have been completely rewritten to use a new color "system" from primer/primitives that is not compatible with the current one. So having separate repos/extensions is less confusing and easier to maintain.

Isn't the point of this theme to match GitHub?

Yes, that has been the goal of this theme from the beginning. But it seems there are a lot of people that use GitHub Dark not because they want it to match github.com, but rather because they specifically like the colors and characteristics of that theme. See 1, 2, 3, 4, 5, 6 and marketplace reviews. I guess the "mistake" was to release a dark GitHub theme even though github.com didn't have a dark mode yet. And assume we can just change it later and most people are ok with it.

Here the first (reverted) attempt we tried:

  • Rename GitHub Dark to GitHub Dark Classic. Move it to a different repo. Let users install it via .vsix. Soon later it also got forked and published on the marketplace.
  • In this repo, change the colors of the GitHub Dark to match github.com

This turned out to be too disruptive for a lot of users.. so here another attempt we're considering:

  • Leave GitHub Dark as is. Also the existing GitHub Light.
  • Publish the new dark theme (that matches github.com) under a different extension with a different name. For example GitHub.com Dark. Also the GitHub.com Light and other new themes that are planned.

Since we only get one shot at naming these themes (without upsetting anyone), we have to be pretty sure it's the right name for the long term. Here a few options that came to mind:

  1. GitHub.com Dark
  2. GitHub Dark+ as suggested above Revert dark changes #123 (comment)
  3. GitHub Dark 2 this would kinda be adding a version number to the theme name. But a bit confusing since this extension is already using 3.0.0.
  4. GitHub Codespaces Dark since initially this theme was created for the Codespaces feature
  5. GitHub Dotcom Dark

Please comment if anyone has more ideas. 🙇 Personally I like GitHub.com Dark the best because it should make it clear what the theme is trying to do.

@johnnyhuy
Copy link

I like the idea of GitHub.com Dark.

Perhaps we can leave a disclaimer on this repo to acknowledge that the scheme here doesn't adhere to the true theme of GitHub.com and that if they're curious they can get a link to the GitHub.com Dark extension page.

@Harry-Harrison
Copy link

Am I right I'm thinking the current setup makes it difficult to have more than two colourways in one extension? Because if not, having a new "GitHub.com" extension that supports the current and all future themes to GitHub.com I feel would be easier to maintain and update?

@joshmanders
Copy link

joshmanders commented Jan 25, 2021

@simurai the problem with the suggestion is that this theme is already considered the official theme. If people see two different GitHub themes, they're gonna look at install count and go "Well I'm gonna go with the one that's installed the most, because that one is most likely the correct one" then you're gonna have issues with people asking why the "official GitHub dark theme" doesn't match github.com

I think it's silly to create a whole new official theme because of the old dark version. This theme is the official GitHub theme, if I switch to dark, I should get the dark theme that matches GitHub's dark theme, not some old theme.

Put in the changelog that the old dark theme is deprecated, here's another repo they can get the .vsix file from if they want to go with that, or they can use VSCode's "install version ..." to go back to the last known version they like.

Pandering to people who complain because the official dark theme has been updated to match the official dark theme on the website and forcing everyone to go to a new theme that is confusing in naming is a strange concept.

What if a year from now the dark theme on the website is changed, am I gonna have to install a 3rd new theme to use that too?

@julio-nf
Copy link

I agree with @joshmanders, If the new dark is the official theme and the one that will be evolved it makes sense to be the default theme of the extension and those who dont like it are instructed to use the previous version with the built-in vscode functionality or with another extension.

@Harry-Harrison
Copy link

Yeah, i agree. I'd like to add, the dark-dark theme is rad and I super appreciate all of the effort put into the site theme and the vscode theme too.

@miguelsolorio
Copy link

My vote would be to have all of the themes under one extension with different theme names (Dark, Dark+, etc.). The "multiple extensions" makes it more confusing to me (as a user) and it's very common for other themes to have multiple variants under the same extension. Maybe the tooling should be updated to reflect this, if that is the ultimate goal?

@simurai
Copy link
Contributor Author

simurai commented Jan 26, 2021

Am I right I'm thinking the current setup makes it difficult to have more than two colourways in one extension?
My vote would be to have all of the themes under one extension with different theme names (Dark, Dark+, etc.).

The new themes have been completely rewritten to use a new color "system" from primer/primitives that is not compatible with the current one. So having separate repos/extensions would keep things simpler. But I think it should still be possible to use two versions of the same npm package. Or because the old colors will not change anymore, we might could just hard code them so that only the newer themes would use the primer/primitives package.

Maybe something to try out.

@tjeastmond
Copy link

Despite opinions, one way or another, I appreciate the effort put into making these themes.

@joshmanders
Copy link

Despite opinions, one way or another, I appreciate the effort put into making these themes.

Yes absolutely, @simurai thank you. I've been a long time user of Dracula Theme everywhere, but I REALLY like the new GitHub dark theme and want to swap Dracula out in everything for it.

@TheOtterlord
Copy link

I am really liking the new theme and love the idea of using GitHub.com Dark as the name.

Since there are a few different names, let's do some unofficial polling.

  • 👍 Github.com Dark
  • 👎 Github Dark+
  • 😄 Github Dark 2
  • 🎉 Github Codespaces Dark
  • 😕 Github Dotcom Dark

@johnnyhuy
Copy link

johnnyhuy commented Jan 27, 2021

So having separate repos/extensions would keep things simpler. But I think it should still be possible to use two versions of the same npm package.

@simurai best choice from a user's perspective would probably having additional themes under the same extension. Though this seems like it would compromise maintainability, hopefully we can try hard-code it for now and keep it legacy in the repo going forward.

we might could just hard code them so that only the newer themes would use the primer/primitives package.

I'm okay with either options, but we can try this out 🙂

@MichaelKheel
Copy link

Thanks a lot for listening to the community and bringing back the old theme. 🥰

@jmotes
Copy link

jmotes commented Jan 27, 2021

Maybe this has already been said - I really liked the appearance of the new theme, but it just had too much contrast between code and background - seemingly even more than the code views on github.com.

I have an astigmatism in one of my eyes that fluctuates due to dry eyes so can't be 100% corrected with glasses and it just made it very evident that I was seeing double text while I didn't have that issue with the old theme.

Would it be possible to make the contrast configurable?

@tri-nga
Copy link

tri-nga commented Jan 27, 2021

Could it be possible to have more themes, (in one repo/extension/bundle) like this?

  • "Github Light"
  • "GitHub Dark" this is the official dark version and matches Github.com
  • "GitHub Dimmed this could have the same colors as GitHub Dark but a dimmed background
  • GitHub Owl it is an example, again, just a differend background color
  • etc etc..

Could it be possible with the new color "system" to generate some few more themes variant, just with a different background color, so to have some contrast alternative?

ps: sorry for my English :)

@simurai
Copy link
Contributor Author

simurai commented Jan 28, 2021

Would it be possible to make the contrast configurable?

There's not some sort of setting to only control the contrast. So it would have to be a different theme, like adding a GitHub.com HighContrast theme. We plan to add more themes to github.com, so this VS Code theme could include them too.

Could it be possible with the new color "system" to generate some few more themes variant, just with a different background color, so to have some contrast alternative?

To only change the editor background color, you could already try that in your VS Code settings.json file. See the Workbench colors docs.

"workbench.colorCustomizations": {
  "editor.background": "#161B22"
}

bg

Small difference might be fine. But if the custom color is too far away from the original, it starts to clash with the rest of the theme.

@stellirin
Copy link

Since it's been stated that the two theme systems are incompatible, why not 'simply' move the unofficial dark theme to a dedicated GitHub Theme (Legacy) and leave it to the community to maintain it.

People that care enough will do the work to find the legacy variant and use it, everyone else will be updated to a theme that is true to the official colours, which is exactly what most people will expect going forwards.

Eventually, people will start opening bugs to show that the theme does not match the official colours etc (if they didn't already).

@Gameghostify
Copy link

Gameghostify commented Feb 2, 2021

@stellirin That was already done, the issue is that too many people found the change too disruptive

@TheOtterlord
Copy link

@Gameghostify I think that was because you had to install it via the file, not in the marketplace 🤔 (I may be wrong here)

@Gameghostify
Copy link

@Gameghostify I think that was because you had to install it via the file, not in the marketplace 🤔 (I may be wrong here)

Some people published it on the marketplace (there just was no official extension)

@simurai
Copy link
Contributor Author

simurai commented Feb 2, 2021

Ok, #132 adds the GitHub.com Light + GitHub.com Dark themes (a 2nd time with a new name) and still keeps the current themes unchanged:

  • GitHub.com Light ✨ new ✨
  • GitHub.com Dark ✨ new ✨
  • GitHub Light stays as is
  • GitHub Dark stays as is

@michaeloliverx
Copy link

@simurai Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.