-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert dark changes #123
Revert dark changes #123
Conversation
What about providing multiple dark themes? I prefer the new dark mode and I install a 2.0.1 version to downgrade from 3.0. |
I also liked the dark-dark version over the grey-dark one. It's the Github theme, it should "match" GitHub, no? |
Guys, you probably received only the feedback from who didn't like the new dark theme, but haven't received from those that loved it, like me. |
At first I didn't like the new dark theme, but after a few hours I loved it. The colors of the text are much easier to see. Maybe launching on the same extension with another name like GitHub Dark+ or something like that would be great. |
I'm with you @julio-nf, initially was hard but now I want it back 😞 Getting back to 2.0.1, but a new theme in different name would be much appreciated. |
I think we should release the offical GitHub.com dark and light theme along with a dimmed version (the old dark theme) all within this one extention. Personaly I like the new dark theme but can see why we need the option for the old dark theme too as it can be easier on the eyes. |
Imho the 2.0.1 dark version has a stronger identity than this revert. I've tried maybe every theme and color scheme out there and now I only have the default Dark+ and the 2.0.1 Github Theme. |
I don't see why caving to complainers, the whole point of this theme is to be GitHub themed, the new dark theme is GitHub's OFFICIAL dark theme, not an alternative created based off the official white theme to satisfy people. IMO the old dark theme should be split out or made as an alternative in this one. Those people who don't like the new official dark theme can fork v1.1.5 and maintain it themselves. |
I agree with the ones who support the new change. |
This makes the most sense I think. Would mean that there's one GitHub theme package with a higher install count and shared updates instead of maintaining multiple repos with fixes and things. |
I also think the grey one should be listed in the same extension under a different name, e.g. "GitHub Dark (legacy)" or something similar. I like the newer one more, but I totally understand why the decision was reverted. For now I'm going to use version 2.0.1 of the extension through VS Code's "Install another version..." option. |
Like others initially I thought the new darker theme was too much, but after a few hours I really liked it. Now the previous dark theme looks a bit washed out. I'd also suggest releasing the old/current dark version under a new theme name is the best way forward and keep this in sync with the official Github colour palette. |
Isn't the point of this theme to match GitHub? What some users think is irrelevant, the only thing that is relevant is that the theme matches GitHub today. If you do not like the theme in GitHub, just do not pick this extension. |
Reverting back to 2.0.1 as well, the update was awesome |
The new dark theme was great; it was a change from the previous one, but it massively aided with contrast and accessibility, and still kept the same great color scheme. I think that reverting it was a little bit silly; change is inevitable, and the changes you guys made were productive, so why go back on them? |
This is technically possible, yes. But the new themes have been completely rewritten to use a new color "system" from primer/primitives that is not compatible with the current one. So having separate repos/extensions is less confusing and easier to maintain.
Yes, that has been the goal of this theme from the beginning. But it seems there are a lot of people that use Here the first (reverted) attempt we tried:
This turned out to be too disruptive for a lot of users.. so here another attempt we're considering:
Since we only get one shot at naming these themes (without upsetting anyone), we have to be pretty sure it's the right name for the long term. Here a few options that came to mind:
Please comment if anyone has more ideas. 🙇 Personally I like |
I like the idea of GitHub.com Dark. Perhaps we can leave a disclaimer on this repo to acknowledge that the scheme here doesn't adhere to the true theme of GitHub.com and that if they're curious they can get a link to the GitHub.com Dark extension page. |
Am I right I'm thinking the current setup makes it difficult to have more than two colourways in one extension? Because if not, having a new "GitHub.com" extension that supports the current and all future themes to GitHub.com I feel would be easier to maintain and update? |
@simurai the problem with the suggestion is that this theme is already considered the official theme. If people see two different GitHub themes, they're gonna look at install count and go "Well I'm gonna go with the one that's installed the most, because that one is most likely the correct one" then you're gonna have issues with people asking why the "official GitHub dark theme" doesn't match github.com I think it's silly to create a whole new official theme because of the old dark version. This theme is the official GitHub theme, if I switch to dark, I should get the dark theme that matches GitHub's dark theme, not some old theme. Put in the changelog that the old dark theme is deprecated, here's another repo they can get the Pandering to people who complain because the official dark theme has been updated to match the official dark theme on the website and forcing everyone to go to a new theme that is confusing in naming is a strange concept. What if a year from now the dark theme on the website is changed, am I gonna have to install a 3rd new theme to use that too? |
I agree with @joshmanders, If the new dark is the official theme and the one that will be evolved it makes sense to be the default theme of the extension and those who dont like it are instructed to use the previous version with the built-in vscode functionality or with another extension. |
Yeah, i agree. I'd like to add, the dark-dark theme is rad and I super appreciate all of the effort put into the site theme and the vscode theme too. |
My vote would be to have all of the themes under one extension with different theme names (Dark, Dark+, etc.). The "multiple extensions" makes it more confusing to me (as a user) and it's very common for other themes to have multiple variants under the same extension. Maybe the tooling should be updated to reflect this, if that is the ultimate goal? |
The new themes have been completely rewritten to use a new color "system" from primer/primitives that is not compatible with the current one. So having separate repos/extensions would keep things simpler. But I think it should still be possible to use two versions of the same npm package. Or because the old colors will not change anymore, we might could just hard code them so that only the newer themes would use the primer/primitives package. Maybe something to try out. |
Despite opinions, one way or another, I appreciate the effort put into making these themes. |
Yes absolutely, @simurai thank you. I've been a long time user of Dracula Theme everywhere, but I REALLY like the new GitHub dark theme and want to swap Dracula out in everything for it. |
I am really liking the new theme and love the idea of using Since there are a few different names, let's do some unofficial polling.
|
@simurai best choice from a user's perspective would probably having additional themes under the same extension. Though this seems like it would compromise maintainability, hopefully we can try hard-code it for now and keep it legacy in the repo going forward.
I'm okay with either options, but we can try this out 🙂 |
Thanks a lot for listening to the community and bringing back the old theme. 🥰 |
Maybe this has already been said - I really liked the appearance of the new theme, but it just had too much contrast between code and background - seemingly even more than the code views on github.com. I have an astigmatism in one of my eyes that fluctuates due to dry eyes so can't be 100% corrected with glasses and it just made it very evident that I was seeing double text while I didn't have that issue with the old theme. Would it be possible to make the contrast configurable? |
Could it be possible to have more themes, (in one repo/extension/bundle) like this?
Could it be possible with the new color "system" to generate some few more themes variant, just with a different background color, so to have some contrast alternative? ps: sorry for my English :) |
There's not some sort of setting to only control the contrast. So it would have to be a different theme, like adding a
To only change the editor background color, you could already try that in your VS Code "workbench.colorCustomizations": {
"editor.background": "#161B22"
} Small difference might be fine. But if the custom color is too far away from the original, it starts to clash with the rest of the theme. |
Since it's been stated that the two theme systems are incompatible, why not 'simply' move the unofficial dark theme to a dedicated People that care enough will do the work to find the legacy variant and use it, everyone else will be updated to a theme that is true to the official colours, which is exactly what most people will expect going forwards. Eventually, people will start opening bugs to show that the theme does not match the official colours etc (if they didn't already). |
@stellirin That was already done, the issue is that too many people found the change too disruptive |
@Gameghostify I think that was because you had to install it via the file, not in the marketplace 🤔 (I may be wrong here) |
Some people published it on the marketplace (there just was no official extension) |
Ok, #132 adds the
|
@simurai Thank you! |
After the
2.0.0
release we got a lot of feedback asking to keep the old dark theme. This reverts all the changes #102 to the Dark theme (also some to Light) and should be the same as1.1.5
.What about the dark theme from github.com?
We're still evaluating the best path forward. An option could be to release all the themes from github.com under a different name. For example
GitHub.com Dark
.