Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punctuation.definition.string - Too high priority #133

Closed
jaymegordo opened this issue Feb 10, 2021 · 7 comments · Fixed by #311
Closed

Punctuation.definition.string - Too high priority #133

jaymegordo opened this issue Feb 10, 2021 · 7 comments · Fixed by #311

Comments

@jaymegordo
Copy link

I'd like to request that you please remove punctuation.definition.string from the vscode-github theme, and replace it with lower priority values, eg:

  • string.quoted.docstring
  • string.quoted.single

etc, I'm sure there's a few more.

punctuation.definition.string is just too high priority and overwrites all string punctuation, which prevents further customization. Eg I'd like to be able to set different colors for normal strings vs docstrings (in python).

Overall though amazing theme, thanks!!
@jaymegordo
Copy link
Author

jaymegordo commented Apr 14, 2021 •
edited
Loading

Commenting again because I see that 4.0.0 is out now but this hasn't been fixed.

in the ~/.vscode/extensions/github.github-vscode-theme-4.0.0/themes/dark.json file, I'm just commenting out this part and it makes the theme more flexible to define colors for different types of strings.
image

And this allows me to specify a different colour for strings vs docstrings, which would otherwise all be captured by punctuation.definition.string as it is a higher priority than string.quoted.single or string.quoted.docstring.

docstrings:
image

normal strings:
image

@jaymegordo
Copy link
Author

Any plans to remove this? would be really appreciated!!

@jaymegordo
Copy link
Author

jaymegordo commented Sep 8, 2021 •
edited
Loading

Another github-vscode-theme released 4.2.1 but this hasen't been fixed yet... please please fix thank you!! @simurai

@jaymegordo
Copy link
Author

5.0.0 out but still not changed... cmon how hard can this be!! Just break punctuation.definition.string into a couple less high-priority categories??

@jaymegordo
Copy link
Author

5.2.2 out now, STILL not fixed please fix thanks!!

@simurai simurai mentioned this issue Jul 15, 2022
Merged
@simurai
Copy link
Contributor

simurai commented Jul 15, 2022

Sorry it took so long. punctuation.definition.string should be removed in the next release.

@jaymegordo
Copy link
Author

I'm on 6.3.3 and this still exists in dark.json...

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove punctuation.definition.string primer/github-vscode-theme
2 participants
@simurai @jaymegordo