Improve TableHandler type annotations
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just moved mypy from pre-commit to tox so it can be tested with a full install (#321), please could you rebase or merge |
|
Thanks! I was going to make a release today, but there's no rush and if you have more stuff to come, I can hold off a bit if you prefer? |
I might have one or two more PRs. The difficult part is actually to group the changes in a way that makes sense logically and is easy to review. |
|
I appreciate these have been in bitesize reviewable chunks :) |
hugovk
changed the title
TableHandler type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.