Include beatmap owners in additional Beatmap API responses #11824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Jan 28, 2025
| @@ -23,7 +23,7 @@ | |||
| */ | |||
| class BeatmapsController extends Controller | |||
| { | |||
| const DEFAULT_API_INCLUDES = ['beatmapset.ratings', 'failtimes', 'max_combo']; | |||
| const DEFAULT_API_INCLUDES = ['beatmapset.ratings', 'failtimes', 'max_combo', 'owners']; | |||
nanaya
requested changes
Jan 28, 2025
| @@ -216,6 +216,7 @@ public function index() | |||
| ::whereIn('beatmap_id', $ids) | |||
| ->whereHas('beatmapset') | |||
| ->with([ | |||
| 'beatmapOwners', | |||
nanaya
reviewed
Jan 28, 2025
Comment on lines
2
to
3
|
|
||
|
|
There was a problem hiding this comment.
oh, while at it
Suggested change
nanaya
reviewed
Jan 28, 2025
| Field | Type | Description | ||
| -------- | ------- | ------------ | ||
| id | integer | [User](#user) id of the Beatmap owner | ||
| username | string | Username of the Beatmap owner |
There was a problem hiding this comment.
I wonder if it's useful to mention about deleted user here
notbakaneko
force-pushed
the
feature/beatmap-owners-more-endpoints
branch
from
dc90e1b to
f7bb58b
Compare
nanaya
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I forget about it again
closes #11788