Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag size on team page #11730

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix flag size on team page #11730

merged 1 commit into from
Dec 9, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 9, 2024

I wonder if the image itself should be resized to 240x120 instead of 256x128 (or the avatar area should be of that size instead, which also integer scaled with current user avatar) ಠ_ಠ

notbakaneko
notbakaneko approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think of weird calling this flag everywhere while using profile avatar 🤨

@notbakaneko notbakaneko merged commit 3358721 into ppy:master Dec 9, 2024
3 checks passed
@nanaya nanaya deleted the team-flag-size branch December 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko