-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc hover/select sound usage updates #14147
Conversation
Currently opening editor triggers a menu open sample, coming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, otherwise looks good.
I've fixed the above with a local guard checking that the menu is not a Possibly arguable that those menus shouldn't have |
Hard one to decide, one may want to perform transforms when showing a menu bar (I can envision that potentially happening with editor at some point). Not playing on |
A few misc changes:
partially addresses #14082