Hide unexpected hit results from appearing on the hit error meter #13381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think these mostly make sense in principle. The thing I'm least sold on is excluding bonus hits from colour display, as it feels to me that some bonuses should maybe count (e.g. extra strong hits and caught bananas), while some probably shouldn't (spinner ticks). But that may be just me and I'm fine with just removing and seeing if anyone complains. |
bdach
approved these changes
Jun 8, 2021
|
I'm not against that, probably fits better as a different colour there. Maybe something like pink/pinklighter... Curious what @peppy thinks too. |
|
I do think bonus showing on the hit error meter could look quite cool with its own colour, but not sure that needs to be done in this PR. Best have that separate I think (can open an issue to track if it's something we don't want to forget about). |
peppy
approved these changes
Jun 9, 2021
peppy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few things I noticed - ignore and bonus judgements were included, tick misses were non-red, and tick hits were the default lighter-blue colour.
I think this makes more sense? Alternative I contemplated is to make ticks white.