Fix pytest and pylint warnings #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
force-pushed
the
fix-warnings
branch
from
756faf0 to
1504d0d
Compare
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
commented
Nov 7, 2024
Comment on lines
-105
to
+109
| columns_values.append(series.values) | ||
| if series.values.size and isinstance(series.values[0], np.bool_): | ||
| # to avoid DeprecationWarning: In future, it will be an error for 'np.bool_' scalars to be interpreted as an index | ||
| columns_values.append(series.values.astype(int)) | ||
| else: | ||
| columns_values.append(series.values) |
There was a problem hiding this comment.
/Users/runner/.local/lib/python3.8/site-packages/pypowsybl/utils/impl/dataframes.py:107: DeprecationWarning: In future, it will be an error for 'np.bool_' scalars to be interpreted as an index
return _pp.create_dataframe(columns_values, columns_names, columns_types, is_index)
There was a problem hiding this comment.
Looks ok to me. I spent some time looking at it a few monthes ago and never found the issue. But now looking at your fix, I understand. They just deprecated automatic conversion on numpy bool array to int array.
| prettytable==2.0.0 | ||
| prettytable==3.11.0 # last version supporting python 3.8 |
There was a problem hiding this comment.
ℹ️ fixes these warning:
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/prettytable/__init__.py:1
/Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/prettytable/__init__.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
import pkg_resources
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138
/Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('mpl_toolkits')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
declare_namespace(pkg)
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138
../../../../hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138
/Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('sphinxcontrib')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
declare_namespace(pkg)
| data=[['GEN', '', 'OTHER', 6.07, -100, 49.99, -100, 100, None, 'MIN_MAX', 1.02, 3.01, True, 'GEN', -3.03, | ||
| data=[['GEN', '', 'OTHER', 6.07, -100, 49.99, -100, 100, nan, 'MIN_MAX', 1.02, 3.01, True, 'GEN', -3.03, |
There was a problem hiding this comment.
ℹ️
FutureWarning: Mismatched null-like values None and nan found. In a future version, pandas equality-testing functions (e.g. assert_frame_equal) will consider these not-matching and raise.
pd.testing.assert_frame_equal(expected, n.get_generators(), check_dtype=False, atol=1e-2)
There was a problem hiding this comment.
For another PR, but we should update our tests so that we don't need anymore check_dtype=False
jeandemanged
changed the title
|
|
geofjamg
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Quality
What is the current behavior?
Many warnings, especially in pytest, making it hard for developers to spot whether new ones are introduced.
Some are real warnings to be adressed, others are pypowsybl deprecated features/apis warnings which should be filtered/checked because expected.
Also some pylint issues to be addressed if relevant.
pytest: 328 warnings
pylint: 9.84/10
pytest
pylint
What is the new behavior (if this is a feature change)?
pytest: 0 warnings
pylint: 9.95/10
Does this PR introduce a breaking change or deprecate an API?