Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Reposition Rename Button bar when importing files #277

Merged
merged 2 commits into from
Mar 1, 2020

Conversation

nashousni
Copy link
Contributor

Signed-off-by: Nassirou NAMBIEMA nassirou.nambiena@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [ x] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
no

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix

What is the current behavior? (You can also link to an open issue here)
Button Bar positioning differs between windows and linux . the replace and rename buttons are distant in windows because rename' s button bar are set to OTHER while replace Button's bar are set to YES

What is the new behavior (if this is a feature change)?
Button Bar positioning are the same between Windows et Linux

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
    no breaking change

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit b55d340 into master Mar 1, 2020
@geofjamg geofjamg deleted the nan/fix_windows_ButtonBar_positioning branch March 1, 2020 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants