Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Dev Tools without needing it installed in Chrome #240

Merged
merged 4 commits into from
Oct 15, 2019
Merged

React Dev Tools without needing it installed in Chrome #240

merged 4 commits into from
Oct 15, 2019

Conversation

ItsRauf
Copy link
Contributor

@ItsRauf ItsRauf commented Oct 14, 2019

Implementation of a standalone react-dev-tools installation in powercord.

src/Powercord/plugins/pc-reactdevtools/index.js Outdated Show resolved Hide resolved
src/Powercord/plugins/pc-reactdevtools/index.js Outdated Show resolved Hide resolved
src/Powercord/plugins/pc-reactdevtools/index.js Outdated Show resolved Hide resolved
src/Powercord/plugins/pc-reactdevtools/index.js Outdated Show resolved Hide resolved
@cyyynthia cyyynthia self-assigned this Oct 14, 2019
@cyyynthia cyyynthia added the enhancement New feature or request label Oct 14, 2019
@cyyynthia
Copy link
Collaborator

Also didn't mentionned it but as you can see in the Travis build the linter isn't happy rn

Copy link
Member

@GriefMoDz GriefMoDz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! - here's my seal of approval.

Now just waiting on Bowser to review these changes/run over some his own extra checks and then we should be on our way for merge. 👍

@cyyynthia cyyynthia merged commit 19433b7 into powercord-org:v2 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants