feat: allow script locals to use global locals #133
Conversation
|
@juliovedovatto if we here https://github.com/posthtml/posthtml-expressions/blob/master/lib/index.js#L164 return normalizeTree(clearRawTag(walk({ locals: { ...locals, ...options.locals }, strictMode: options.strictMode }, tree)), tree.options)Then we could just pass default values in script locals like below. <script locals>
module.exports = {
title: 'Really default title',
}
</script>I did test and seem works, did am I missing something? What do you think? |
|
|
|
Yes I understand that it's better if you do something with locals inside the script, but in that case you can create new local, example: <script locals>
const first = 'John';
const last = 'Doe';
module.exports = {
firstName: first,
lastName: last,
fullName: (locals.firstName || first) + ' ' + (locals.lastName || last);
}
</script>But yes it's depend.. If you want just return always default or provided, then it's better do like now. In my new component plugin I added both way where you can define if locals is overridden (default behavior) or if it's being used by locals script (named computed). I will write more about it in next days. |
Proposed Changes
The intent of this PR is to add support to allow script locals to use global locals defined.
I faced a situation simular to #132, where I needed to access a global value from my template file, while using the
posthtml-includeplugin.Example:
Generated output:
Types of Changes
What types of changes does your code introduce
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is a reminder of what we are going to look for before merging your
code.
Further Comments
If this is a large or complex change, kick off the discussion by explaining why
you chose the solution you did and what alternatives you considered, etc...
Reviewers: @mrmlnc, @jescalan, @michael-ciniawsky, @posthtml/collaborators