Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postcss-sorting to plugins list #669

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Add postcss-sorting to plugins list #669

merged 1 commit into from
Dec 11, 2015

Conversation

hudochenkov
Copy link
Contributor

postcss-sorting is a plugin to sort rules content with specified order.

@TrySound
Copy link
Member

Seems like duplicating css-property-sorter. Also it does not follow guidelines. Plugin should use async methods where it's possible.

@hudochenkov
Copy link
Contributor Author

@TrySound it's absolutely not duplicating. css-property-sorter sort only properties. My plugin sort also at-rules, nested rules, variables; can group nodes. Also not breaks nesting (css-property-sorter does). css-property-sorter sorts only properties (plugin name and readme very clear about this) in not nested rules, my plugin sort all rule's content in nested (or not) rules.

About async I agree. I don't know how to replace sync with async yet.

@TrySound
Copy link
Member

@hudochenkov U can see in css-property-sorter. Are you sure that rules sorting not breaks rendered styles?

@hudochenkov
Copy link
Contributor Author

@TrySound as I tested on complex stylesheets it's not break styles. Style rendering done by PostCSS itself. Obviously edge cases may exists, no one can write software without bugs :)

ai added a commit that referenced this pull request Dec 11, 2015
Add postcss-sorting to plugins list
@ai ai merged commit 43b6c9f into postcss:master Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants