Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tuner app #2429

Merged
merged 3 commits into from
Dec 18, 2024
Merged

add tuner app #2429

merged 3 commits into from
Dec 18, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 17, 2024 •
edited
Loading

the sample rate is tricky: it's either need to:

  • implement uint to the Rate enum
  • implement the Rate enum to uint
  • record both in map.vec

(because audio::set_rate need the Rate enum and the request beep using uint)

I choose implement the Rate enum to uint

@zxkmm zxkmm marked this pull request as ready for review December 18, 2024 08:07
@zxkmm zxkmm enabled auto-merge (squash) December 18, 2024 08:09
@zxkmm zxkmm mentioned this pull request Dec 18, 2024
Merged
gullradriel
gullradriel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not. Good to go.

@zxkmm zxkmm merged commit ead9449 into portapack-mayhem:next Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel