Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdcard format detect and warn user #2420

Merged
merged 5 commits into from
Dec 14, 2024
Merged

sdcard format detect and warn user #2420

merged 5 commits into from
Dec 14, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 13, 2024

  • add format detect in sdcard debug app
  • if sdcard format isn't correct, warn user in home screen
  • let another warn (external app dir empty warn) at the top instead of it's own place where inserted the tile.

@zxkmm zxkmm marked this pull request as ready for review December 13, 2024 07:48
gullradriel
gullradriel approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We will see if it's helping users or not.
Do not forget to explain to me the ui_widget modifications before closing the conversations and merge ^^

@gullradriel gullradriel merged commit 5075349 into portapack-mayhem:next Dec 14, 2024
3 checks passed
@zxkmm zxkmm mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel