Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ook Editor adjustements #2366

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Ook Editor adjustements #2366

merged 15 commits into from
Nov 19, 2024

Conversation

gullradriel
Copy link
Member

@gullradriel gullradriel commented Nov 18, 2024 •
edited
Loading

OOK Remote Editor adjustements

GUI preview

image

Changes

  • aligned GUI
  • renamed LowBit to PauseSymbol and added unit (us)
  • renamed HighBit to SymbolRate, added the unit (symbols/s)
  • renamed BitTimeStep to Field Step (still used for both Pause and SymbolRate)
  • made ook_file_data a full API with load / save / play
  • cannot TX if no payload
  • cannot save if no payload
  • renamed the app OOK Editor after some discord comments

Side note

The (generic) Remote app adjustements will be done in another PR (make remote app external, implement ook files, wave files in the buttons)

@gullradriel gullradriel marked this pull request as ready for review November 19, 2024 11:58
@gullradriel gullradriel changed the title Ook remote adjustements Ook ~remote~ Editor adjustements Nov 19, 2024
@gullradriel gullradriel changed the title Ook ~remote~ Editor adjustements Ook Editor adjustements Nov 19, 2024
@gullradriel gullradriel requested review from htotoo and zxkmm November 19, 2024 15:14
zxkmm
zxkmm approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read and tested, looks good enough to me
feel free to wait for others' approval if they maybe can find something more than me

@gullradriel gullradriel merged commit ff54f59 into portapack-mayhem:next Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkmm zxkmm zxkmm approved these changes

@htotoo htotoo Awaiting requested review from htotoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gullradriel @zxkmm