Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmeove my name cuz there's a better serial dbg tool #2291

Merged
merged 2 commits into from
Oct 11, 2024
Merged

rmeove my name cuz there's a better serial dbg tool #2291

merged 2 commits into from
Oct 11, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 10, 2024 •
edited
Loading

this is a comments only safe PR

  • removed a link that should be replaced
  • remove the linker hint comments cuz there's already one app is using asyncmsg

@zxkmm zxkmm marked this pull request as ready for review October 10, 2024 16:52
@zxkmm zxkmm enabled auto-merge (squash) October 10, 2024 16:54
gullradriel
gullradriel approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to keep your original edit, but I think my rework sounds better.

firmware/application/usb_serial_asyncmsg.hpp Outdated Show resolved Hide resolved
@zxkmm zxkmm merged commit 5a00669 into portapack-mayhem:next Oct 11, 2024
3 checks passed
@zxkmm zxkmm deleted the remove_my_name branch October 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel