Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue from PR#1444 #2278

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix issue from PR#1444 #2278

merged 1 commit into from
Oct 2, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 2, 2024

the issue is: the text_format widget display wrongly.

  • previously before PR#1444, this code using the for loop below to generate the format_string, which MAYBE to prevent showing the S symbol.
  • but after PR#1444, the entireh of symfield code not compatible with this design anymore.
  • however the encoder_def struct itself has a field called word_format, which exactly be able to use as the format_string,
  • because itself is ONLY a hint text, not impact protocol things.
  • When you find OOK protocol is broken and see this commit from git blame, please be aware that it's not from here.
  • previously me and @cusspvz already found it broken, before 1444 and before this PR. And this commit is just to fix the broken that from PR SymField rewrite #1444.

@zxkmm zxkmm marked this pull request as ready for review October 2, 2024 14:11
@gullradriel gullradriel self-requested a review October 2, 2024 14:16
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gullradriel gullradriel merged commit e75fb59 into portapack-mayhem:next Oct 2, 2024
3 checks passed
@zxkmm zxkmm deleted the ook_fix branch October 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants