Skip to content

Commit

Permalink
[ADR][API] Update ADR for providing locales after changing the approach
Browse files Browse the repository at this point in the history
  • Loading branch information
GSadee committed Mar 15, 2022
1 parent 46ad6e1 commit 4e82e09
Showing 1 changed file with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Using data provider for getting available locales in active channel for shop user
# Using Doctrine Collection extension for getting available locales in active channel for shop user

* Status: proposed
* Date: 2021-07-05
* Status: accepted
* Propose date: 2021-07-05
* Update date: 2022-03-15

## Context and Problem Statement
Customer should have access only to locales available in their channel
Expand All @@ -16,11 +17,11 @@ Customer should have access only to locales available in their channel

### Using Data Provider

* Good, because we already have this approach for older resources
* Good, because it is easy to implement
* Bad, because using data providers omits extra Doctrine extensions like pagination

## Decision Outcome

Chosen option: Using Data Provider
Shops shouldn't have many locales for each channel, so lack of a pagination is smaller problem than creating overcomplicated query in Doctrine Collection extension
Chosen option: **"Using Doctrine Collection extension"**

This option is consistent with current approach and does not omit Doctrine extensions like pagination.

0 comments on commit 4e82e09

Please sign in to comment.