Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sass support #55

Merged
merged 16 commits into from
Apr 19, 2015
Merged

Add Sass support #55

merged 16 commits into from
Apr 19, 2015

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 26, 2014

This overhauls everything and adds Sass support to the styles.

  • .scss files are stored in _scss.
  • css/styles.scss compiles into _site/css/styles.css.
  • This replaces the Liquid includes I was previously using for the syntax highlighting.
  • Reduces two CSS calls—one for poole.css and one for the syntax—into a single file.
  • Breaks styles up into individual .scss files.

This PR represents the bulk of the work going into v2.

@mdo mdo added this to the v2.0.0 milestone Sep 26, 2014
@mdo mdo self-assigned this Sep 26, 2014
@flippyhead
Copy link

This looks great. Would be nice to see any notes on migrating from existing sites to v2.0.0 😉

@nickserv
Copy link
Contributor

You beat me to it! I'm liking this so far, I'm going to check if there's anything significant in my branch that isn't here, since I also tried some other Jekyll 2 related changes.

@nickserv
Copy link
Contributor

I just looked over the changes in my scss branch and as far as style organization goes, they're not nearly as cool as your changes. However, I started some other Jekyll 2 stuff that isn't here yet (like front matter defaults), and I'd like to send a pull request when this is merged (or I could send a pull request based off of this branch before then).

@nickserv nickserv mentioned this pull request Sep 30, 2014
Closed
@rmorrin
Copy link

rmorrin commented Dec 9, 2014

Are there any updates on this one yet? I've been using this branch locally and things look good - curious as to why this hasn't been merged yet! 😄

@nickserv
Copy link
Contributor

nickserv commented Dec 9, 2014

There are some values, especially color values, that seem to be repeated in the new scss files. We should probably use variables for them.

@mdo
Copy link
Member Author

mdo commented Apr 19, 2015

@nicolasmccurdy Good points! I've addressed most of those in the latest commits, and should have some more CSS changes to push up in just a bit.

mdo added a commit that referenced this pull request Apr 19, 2015
@mdo
Merge pull request #55 from poole/sass
20d86be 
Add Sass support
@mdo mdo merged commit 20d86be into master Apr 19, 2015
@mdo mdo deleted the sass branch April 19, 2015 06:26
nmasse-itix pushed a commit to nmasse-itix/nmasse-itix.github.io that referenced this pull request Jun 14, 2016
@mdo
Merge pull request poole#55 from jylitalo/sort-pages-in-sidebar
f37d053 
sort pages in sidebar into logical order (alphabetically by url)
virtual pushed a commit to virtual/blog that referenced this pull request Oct 1, 2020
@cotes2020
Support the mathematical expressions (poole#55).
ef3fc7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdo mdo

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mdo @flippyhead @nickserv @rmorrin