Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _config.yaml #113

Merged
merged 3 commits into from
Feb 7, 2016
Merged

Update _config.yaml #113

merged 3 commits into from
Feb 7, 2016

Conversation

smutek
Copy link
Contributor

@smutek smutek commented Nov 16, 2015

Remove relative_permalinks: true and adds jekyll-paginate & jekyll-gist gems from _config.yml allowing for an error free jekyll serve

Remove line 5 - relative_permalinks: true from _config.yml

Fixes the "Since v3.0, permalinks for pages in subfolders must be relative to the site source directory..." error that is thrown when running jekyll serve
- Add jekyll-paginate gem. Fixes "Deprecation: You appear to have pagination turned on, but you haven't included the `jekyll-paginate` gem.' error when running jekyll serve.

- Add jekyll-gist gem. Fixes "Liquid Exception: Liquid syntax error: Unknown tag 'gist'" errors when running jekyll serve.
@kigster
Copy link

kigster commented Nov 26, 2015

Please merge this PR – without it Poole does not work on Jekyll 3.*

@kotse
Copy link

kotse commented Dec 31, 2015

This should be merged - new users are not supposed to lose time over this, when the configuration clearly says

just download Poole and start up Jekyll

Well it obviously doesn't...

That said, small documentation change is also needed with this commit - because those new required gems will not install themselves ;)

@nickserv
Copy link
Contributor

I agree that Jekyll 3 should be supported and that there should be more documentation about Jekyll 3 either way. However, wouldn't this change functionality on Jekyll 2, causing permalinks to be different? It's important to note that GitHub Pages is still using Jekyll 2 for now, so we don't want to break anything that uses it.

Also, there should be a Gemfile with these additional gem dependencies to make setup easier.

@kotse
Copy link

kotse commented Jan 1, 2016

Valid point :)

So its better to put all Jekyll3 related in a separate branch jekyll_v3, with Gemfile, proper README...

And just update README on master so people know where to look

@nickserv
Copy link
Contributor

nickserv commented Jan 2, 2016

@kotse It would be great if Jekyll 3 compatability could be implemented without affecting Jekyll 2, but if that isn't possible I would prefer a separate branch.

mdo added a commit that referenced this pull request Feb 7, 2016
@mdo mdo merged commit fcda652 into poole:master Feb 7, 2016
@mdo mdo added this to the v3.0.0 milestone Feb 7, 2016
@smutek smutek deleted the update_config branch February 7, 2016 07:27
virtual pushed a commit to virtual/blog that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants