-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _config.yaml #113
Update _config.yaml #113
Conversation
Remove line 5 - relative_permalinks: true from _config.yml Fixes the "Since v3.0, permalinks for pages in subfolders must be relative to the site source directory..." error that is thrown when running jekyll serve
- Add jekyll-paginate gem. Fixes "Deprecation: You appear to have pagination turned on, but you haven't included the `jekyll-paginate` gem.' error when running jekyll serve. - Add jekyll-gist gem. Fixes "Liquid Exception: Liquid syntax error: Unknown tag 'gist'" errors when running jekyll serve.
Please merge this PR – without it Poole does not work on Jekyll 3.* |
This should be merged - new users are not supposed to lose time over this, when the configuration clearly says
Well it obviously doesn't... That said, small documentation change is also needed with this commit - because those new required gems will not install themselves ;) |
I agree that Jekyll 3 should be supported and that there should be more documentation about Jekyll 3 either way. However, wouldn't this change functionality on Jekyll 2, causing permalinks to be different? It's important to note that GitHub Pages is still using Jekyll 2 for now, so we don't want to break anything that uses it. Also, there should be a Gemfile with these additional gem dependencies to make setup easier. |
Valid point :) So its better to put all Jekyll3 related in a separate branch And just update README on master so people know where to look |
@kotse It would be great if Jekyll 3 compatability could be implemented without affecting Jekyll 2, but if that isn't possible I would prefer a separate branch. |
Remove relative_permalinks: true and adds jekyll-paginate & jekyll-gist gems from _config.yml allowing for an error free jekyll serve