[RFC 61] Add Modulo Operator (and floored division) #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the corresponding checked and partial variants for integers.
also add fldc, fld_unsafe, fld_partial and modc, mod_unsafe, mod_partial
and add unsafe variants
mfelsche
added
do not merge
mfelsche
commented
Jan 30, 2019
|
Also i did not implement Also, outside the scope of this RFC, but what about |
|
Some properties mentioned in the RFC have been verified here (when run against ponyc built from this branch): https://github.com/mfelsche/stdlib-properties/blob/master/stdlib-properties/main.pony#L82-L100 |
|
@mfelsche RFC includes updates to the tutorial. I don't want to merge this until that is also available as the tutorial changes were part of the RFC that was accepted. |
jemc
reviewed
Feb 5, 2019
|
tutorial PR is here: ponylang/pony-tutorial#347 |
jemc
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of RFC 61.
This PR adds the following methods to the number classes hierarchy and adds the implementation to each stdlib implementation (U8, U16, ... I8, I16, ..., F32, F64):
RealfldmodIntegerfld_unsafefld_partialfldcmod_unsafemod_partialmodcFloatingPointfld_unsafemod_unsafe