Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows build system to handle the latest Visual Studio 2017 version #2992

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Update Windows build system to handle the latest Visual Studio 2017 version #2992

merged 2 commits into from
Jan 29, 2019

Conversation

chalcolith
Copy link
Member

This PR:

  • Updates our copy of the WAF python program, which can handle the latest VS 2017 version.
  • Updates our wscript build file to accept the latest versions of the Visual Studio compiler.
  • Updates ponyc to use Microsoft's vswhere utility to determine where to find the Microsoft linker.

Fixes #2991

@chalcolith chalcolith added changelog - added Automatically add "Added" CHANGELOG entry on merge windows labels Jan 28, 2019
@SeanTAllen SeanTAllen self-requested a review January 29, 2019 00:33
@SeanTAllen
Copy link
Member

SeanTAllen commented Jan 29, 2019 •
edited
Loading

@kulibali any idea why this error would come up? are our non-release CI jobs trying to upload bintray?
screenshot 2019-01-28 20 18 27

I don't see any indication that it is, so, I'm confused by the error. Anyway, rerunning that one.

@chalcolith
Copy link
Member Author

They're only supposed to deploy to BinTray for the release branch. Perhaps this is AppVeyor uploading to its own CDN?

@SeanTAllen SeanTAllen merged commit 8869d35 into ponylang:master Jan 29, 2019
@SeanTAllen SeanTAllen deleted the fix_2991 branch January 29, 2019 04:08
ponylang-main added a commit that referenced this pull request Jan 29, 2019
@ponylang-main
Update CHANGELOG for PR #2992 [skip ci]
3429a8e
@SeanTAllen
Copy link
Member

Thanks @kulibali. Is this something that should be released soon or can it wait til March-ish when we have the next release scheduled?

@chalcolith
Copy link
Member Author

I think it's fine to wait until the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen approved these changes

Assignees
No one assigned
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalcolith @SeanTAllen