Fix compilation warning on windows. #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kulibali can you verify/comment on this? |
|
The change looks fine to me. However, I cannot repro the issue itself. Ponyc master builds without warnings for me with VS2017 15.8.3, using @fohly, can you provide more context for this, please? What version of VS are you using, and how are you building ponyc (using |
|
Building with make.bat. I think it uses VS 2015. Error message: |
chalcolith
approved these changes
Sep 11, 2018
|
Not sure what went wrong with the ARM CI build, but it doesn't seem related. |
chalcolith
added
changelog - fixed
chalcolith
changed the title
mfelsche
changed the title
|
Indeed worrying but completely unrelated, merging. |
ponylang-main
added a commit
that referenced
this pull request
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code results in a warning, and since warnings are treated as errors, the compilation fails.