Fix File.writev and File.flush in cases where the IO vector exceeds IOV_MAX. #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is just one of several issues I encountered with the #2526 is a separate issue. |
dipinhora
approved these changes
Jun 9, 2018
SeanTAllen
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
_pending_writesIO vector insideFileexceedsIOV_MAX, we enter a loop of iterating over chunks of the IO vector of size less than or equal toIOV_MAXin count. This loop was invalid, causing out-of-bounds array accesses that bubbled up anerror.This PR fixes the loop logic, and updates the tests to catch such issues.
It also cleans up some of the code and comment formatting issues in
File._write_to_disk.