Fix CommandSpec without args and help #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 29, 2018 12:38
and fix OptionStop test
which was considered CommandSpec.parent and thus got a subcommand added in add_help. Added a _type field to differentiate the two types of CommandSpecs properly.
mfelsche
added
the
changelog - fixed
jemc
approved these changes
Jun 1, 2018
ponylang-main
added a commit
that referenced
this pull request
Jun 1, 2018
|
Thanks for taking care of this. |
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
* fix cli example for Env.vars now being a field * include cli tests in stdlib test suite and fix OptionStop test * fix CommandSpec.leaf without args and with help added which was considered CommandSpec.parent and thus got a subcommand added in add_help. Added a _type field to differentiate the two types of CommandSpecs properly.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And Actually run the cli tests (that weren't passing).
To fix the case of a
CommandSpec.leafwithout args and with help i added a_typefields and getters for properly determining if aCommandSpecis a parent or a leaf. I would be more comfortable with having two different classes here that share a common trait, but i tried going that route and it entails some breaking API changes that need to go through the RFC process. I decided to ease the pain for now with this fix, but will most likely do a separate RFC soon.