Add Integer.bit_reverse, exposing the llvm.bitreverse intrinsic. #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
added
the
changelog - added
jemc
force-pushed
the
feature/integer-bit-reverse
branch
from
7711b88 to
956da92
Compare
mfelsche
reviewed
May 24, 2018
| @@ -257,6 +257,7 @@ trait val Integer[A: Integer[A] val] is Real[A] | |||
| fun op_xor(y: A): A => this xor y | |||
| fun op_not(): A => not this | |||
|
|
|||
| fun bit_reverse(): A | |||
There was a problem hiding this comment.
may i ask you for a little docstring, maybe even with an example? :)
There was a problem hiding this comment.
Good call. Added in b85220b.
|
travis OSX build seemed to have been hanging. I restarted. |
|
Is this ready to be added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a need for bit reverse semantics, noticed that
Integerhasbswapwhich exposes thellvm.bswapintrinsic, but thellvm.bitreverseintrinsic was missing.So this PR adds the exposure of that missing intrinsic.