Fix unsafe cases in capability subtyping implementation #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
added
the
changelog - fixed
This fixes a bug in the capability subtyping implementation where capabilities were being treated as subtypes of themselves, and adds exhaustive tests for capability subtyping.
Praetonus
force-pushed
the
fix-cap-subtype
branch
from
a89db6c to
2157833
Compare
Praetonus
added
needs discussion during sync
do not merge
|
@Praetonus why is this marked as do not merge? @sylvanc took a look during sync and this looks good to him. |
|
@Praetonus - any update on this one? If it looks good to others, should we continue? |
|
This should be good to go. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the capability subtyping implementation where capabilities were being treated as subtypes of themselves, and adds exhaustive tests for capability subtyping.
Closes #2601.