Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable -avx512f on LLVM < 5.0.0 to avoid LLVM bug 30542 #2475

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Disable -avx512f on LLVM < 5.0.0 to avoid LLVM bug 30542 #2475

merged 1 commit into from
Jan 9, 2018

Conversation

dipinhora
Copy link
Contributor

Prior to this commit, we could accidentally trigger llvm bug 30542
(https://bugs.llvm.org/show_bug.cgi?id=30542) on a cpu with the
avx512f feature. See WallarooLabs/wally#1925
for one particular example of this occurring.

This commit automagically disables avx512f if the LLVM in use is
below version 5.0.0 to work around the issue.

@dipinhora
Disable -avx512f on LLVM < 5.0.0 to avoid bug 30542
e0cc5f6 
Prior to this commit, we could accidentally trigger llvm bug 30542
(https://bugs.llvm.org/show_bug.cgi?id=30542) on a cpu with the
`avx512f` feature. See WallarooLabs/wally#1925
for one particular example of this occurring.

This commit automagically disables `avx512f` if the LLVM in use is
below version 5.0.0 to work around the issue.
@SeanTAllen
Copy link
Member

NIce sleuthing @dipinhora and @slfritchie.

SeanTAllen
SeanTAllen approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@SeanTAllen SeanTAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. I'd like to hear feedback from others though.

@SeanTAllen SeanTAllen changed the title Disable -avx512f on LLVM < 5.0.0 to avoid bug 30542 Disable -avx512f on LLVM < 5.0.0 to avoid LLVM bug 30542 Jan 9, 2018
@SeanTAllen SeanTAllen added changelog - changed Automatically add "Changed" CHANGELOG entry on merge triggers release Major issue that when fixed, results in an "emergency" release labels Jan 9, 2018
@SeanTAllen SeanTAllen merged commit bd4f985 into ponylang:master Jan 9, 2018
ponylang-main added a commit that referenced this pull request Jan 9, 2018
@ponylang-main
Update CHANGELOG for PR #2475 [skip ci]
0c8d121
@SeanTAllen SeanTAllen mentioned this pull request Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen approved these changes

Assignees
No one assigned
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge triggers release Major issue that when fixed, results in an "emergency" release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipinhora @SeanTAllen