Fix double free in expr_typeref #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ast_settype` automatically frees the previous type AST so we shouldn't call `ast_free` manually afterwards.
|
I'm curious, how did you find this? |
|
@winksaville With valgrind, while trying to trace down the crashes in #2449. |
|
Nice, maybe we should be running valgrind and other test tools constantly? This hang in stdlib I found was because I was looking into the spurious failure bug, so I was running stdlib until failure. |
|
For valgrind specifically I don't think it would be feasible as it would slow down CI builds by several orders of magnitude. |
jemc
added
the
changelog - fixed
jemc
approved these changes
Jan 5, 2018
|
Actually, I was thinking maybe we could get volunteers to run long term tests as a low priority job on "their" computers, just a thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ast_settypeautomatically frees the previous type AST so we shouldn't callast_freemanually afterwards.