Remove unused FormatSettings interface and related types. #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface was from the old Stringable API, which was removed in #1286 There's no reason to keep this around anymore, as the new Format API accepts an argument list instead of a FormatSettings object. I think this interface should have been removed in that PR, but was overlooked. This commit also reorganizes the other types from the same file, so that they are better namespaced in keeping with the file naming convention of the standard library.
jemc
added
the
changelog - changed
Theodus
approved these changes
Dec 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface was from the old
StringableAPI, which was removed in#1286
There's no reason to keep this around anymore, as the new Format API
accepts an argument list instead of a FormatSettings object. I think
this interface should have been removed in that PR, but was overlooked.
This commit also reorganizes the other types from the same file,
so that they are better namespaced in keeping with the file naming
convention of the standard library.