Fix incorrect detection of exhaustive matches for structural equality comparisons on some primitives. #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for primitives that have custom 'eq' methods or implement Equatable[T] where T is a subtype of the primitive. The type was inferred by looking at the type of the full case AST which was inferred from the first argument of the eq method. Now the exhaustive match logic is considering the actual type of the case expression.
mfelsche
added
the
changelog - fixed
jemc
requested changes
Nov 16, 2017
|
It was failing on OSX for the stdlib tests compiled in release mode: restarting the job. |
|
@jemc added that test |
jemc
approved these changes
Nov 17, 2017
jemc
changed the title
ponylang-main
added a commit
that referenced
this pull request
Nov 17, 2017
|
Great work! |
|
It was a pleasure, an honour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for primitives that have custom 'eq' methods or implement Equatable[T] where T is a subtype of the primitive.
The type was inferred by looking at the type of the full case AST which was inferred
from the first argument of the eq method. Now the exhaustive match logic is
considering the actual type of the case expression.
This should fix #2327