Make Payload.respond() send given parameter, not this.
#2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfelsche
previously approved these changes
Nov 6, 2017
mfelsche
requested changes
Nov 6, 2017
packages/net/http/payload.pony
Outdated
| @@ -248,7 +248,7 @@ class trn Payload | |||
| Start sending a response from the server to the client. | |||
| """ | |||
| try | |||
| (session as HTTPSession)(this) | |||
| (session as HTTPSession)(response') | |||
There was a problem hiding this comment.
it must be consume response'
|
My bad. Fixed! |
surma
force-pushed
the
payload-respond-fix
branch
from
57683cb to
34523e3
Compare
mfelsche
approved these changes
Nov 6, 2017
mfelsche
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Nov 10, 2017
|
Thanks @surma! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.