Fix broken "make" command #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My PR to introduce support for DragonFlyBSD added /usr/local/lib to the linker search path. We assumed this would be harmless, however it was not. Because /usr/local/lib was added to the path in a fashion where it would appear before the local "build" directory then the following would happen: - Run `make` - Get a linker failure if you'd previously installed ponyc Whereas - Run `make` install - No linker error The problem occured because the pony libraries in /usr/local/lib were being used instead of those in build. This PR moves the addition of /usr/local/lib to being AFTER build path. Closes #2219
SeanTAllen
added
the
changelog - fixed
|
This worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR to introduce support for DragonFlyBSD added /usr/local/lib to the
linker search path. We assumed this would be harmless, however it was
not. Because /usr/local/lib was added to the path in a fashion where it
would appear before the local "build" directory then the following would
happen:
makeWhereas
makeinstallThe problem occured because the pony libraries in /usr/local/lib were
being used instead of those in build.
This PR moves the addition of /usr/local/lib to being AFTER build path.
Closes #2219