Add Array.swap_elements and various Random methods (RFC 46). #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
changed the title
jemc
force-pushed
the
feature/random-methods
branch
from
2ca86f8 to
61c8fc8
Compare
|
Add a test for "swap elements"? |
|
I'm not sure that the usual CHANGELOG tag will properly capture this change. Manual CHANGELOG entries to cover the different additions? |
|
i took the freedom to add the requested test. |
mfelsche
force-pushed
the
feature/random-methods
branch
from
30a6313 to
ff56d02
Compare
|
i extended my claimed freedom to rebase and also add a manual changelog entry. |
|
Restarting the OSX Travis builds that failed to see if they were a fluke... |
Theodus
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2127.