Add ability to default enable PIC when compiling ponyc #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
approved these changes
Jul 31, 2017
|
More than 1 person has requested this. This is nice. |
Praetonus
reviewed
Jul 31, 2017
|
@Praetonus Having If others agree that adding |
|
I feel like |
This commit allows folks compiling from source (for packaging or for their own use) to easily specify that `ponyc` should by default compile programs using Position Independent Code (PIC). The main driving force behind this is a smoother user experience for folks on distributions where PIC is enabled by default so they don't have to always remember to pass `--pic` to `ponyc` when compiling programs. Alpine Edge is one such example. With this change, packaging for Alpine Edge is as simple as `make default_pic=true` and then users of `ponyc` on Alpine Edge don't need to be aware of PIC being enabled by default at all and don't have to remember to pass `--pic` to every invocation of `ponyc`. This commit also adds the ability to specify `--nopic` to disable PIC if `ponyc` was compiled with `default_pic=true`. NOTE: This does not change the default behavior of `ponyc` when not compiling with `default_pic=true` and it is mainly a convenience meant to be used only when the person compiling knows that the toolset being used (gcc on a distro with PIC enabled by default) will cause issues otherwise.
|
Makes sense. PR updated to add |
dipinhora
changed the title
|
@Praetonus does this look good to you? |
SeanTAllen
added
the
changelog - added
Praetonus
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows folks compiling from source (for packaging or
for their own use) to easily specify that
ponycshould alwayscompile programs using Position Independent Code (PIC). The main
driving force behind this is a smoother user experience for folks
on distributions where PIC is enabled by default so they don't
have to always remember to pass
--pictoponycwhen compilingprograms. Alpine Edge is one such example. With this change,
packaging for Alpine Edge is as simple as
make force_pic=trueand then users of
ponycon Alpine Edge don't need to be awareof PIC being enabled by default at all and don't have to remember
to pass
--picto every invocation ofponyc.NOTE: This does not change the default behavior of
ponycwhennot compiling with
force_pic=trueand it is mainly a conveniencemeant to be used only when the person compiling knows that the
toolset being used (gcc on a distro with PIC enabled by default)
will cause issues otherwise.
@ponylang/core This is related to #1811 and #1484 where alternate solutions have been discussed. Hopefully this is an acceptable compromise until the longer term solutions previously discussed can be implemented.