Fix compiler assertion failure at code generation #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an assertion failure that occurred when generating forwarding functions boxing non-ref tuples. The tuple AST without reference capabilities was being used, which could be a non-reachable type, resulting in an assertion failure in `gen_box`. Closes ponylang#2097.
Praetonus
added
the
changelog - fixed
|
@Praetonus should we do a release for this? how common is this problem? I'm thinking "yes" |
|
@SeanTAllen I don't have any objections on a release. Maybe a minor one though, since we didn't make any breaking change since 0.16.0. |
|
Ya seems reasonable. I'm going to hold off until we can get the bug that was reported in IRC that @autodidaddict is going to open a report for before releasing. Not sure if you have seen that @Praetonus. Its a new bug from one of your commits that went out in 0.16.0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an assertion failure that occurred when generating forwarding functions boxing non-ref tuples. The tuple AST without reference capabilities was being used, which could be a non-reachable type, resulting in an assertion failure in
gen_box.Closes #2097.