Fix compiler assertion failure on unused reference to _
#2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
added
the
changelog - fixed
jemc
reviewed
Jul 26, 2017
| " _\n" | ||
| " end"; | ||
|
|
||
| TEST_COMPILE(src); |
There was a problem hiding this comment.
Do we really want to allow this? It seems like _ should only be used where you would otherwise be forced to give an identifier, not as an empty branch "filler" (None should be used for that).
There was a problem hiding this comment.
We currently allow _ anywhere an identifier is allowed, except when the value would be needed. I don't really see a problem with allowing _ in the fixed case, and I'm also not sure where we'd draw the line between allowed and forbidden.
jemc
changed the title
__
ponylang-main
added a commit
that referenced
this pull request
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2073.