Fix boxed tuple identity when type identifiers differ #2009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, boxed tuples with different type identifiers wouldn't be considered as having the same identity even when containing the same objects, for example when comparing
(U32(0), U32(0))
through(U32, U32)
and(Any, Any)
tuples.The new identity algorithm for boxed values follows. "unchanged" means that this step of the algorithm didn't need any changes.
memcmp
(unchanged)__is
functionThe algorithm of the
__is
function was also changed. Since it now needs to compare against any possible type, multiple cases are generated in the function, which each case unboxing to a particular type and doing the comparison. The case to execute is chosen based on the type ID of the RHS object.Fixes #1950.