Fix extreme CPU use in scheduler on Windows #1785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1625 (50% CPU usage for a simple timer demo) for Windows.
Inspired by the ancient wisdom of Joe Duffy, we now yield a Pony scheduler thread by calling
Sleep(1)
instead ofSleep(0)
. This results in a sleep of anywhere from 1 to 16 milliseconds, depending on the global value of the system timer.The example in #1625 now runs with minimal CPU usage on my system. Comparing
libponyrt.benchmarks
before and after the change doesn't seem to show a significant difference.