Support XCode 8.3 and LLVM 3.9 #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used llvm-ar-3.8 if it was available. This doesn't work with XCode 8.3, which will issue a link error. Instead, we now pick up the llvm-ar from the `llvm-config --bindir` directory if it is available, and otherwise fall back. As part of this change, the homebrew location for llvm@3.9's llvm-config is tried if no LLVM_CONFIG is specified.
SeanTAllen
added
the
changelog - added
ponylang-main
added a commit
that referenced
this pull request
Mar 28, 2017
JONBRWN
added a commit
to WallarooLabs/ponyc
that referenced
this pull request
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used llvm-ar-3.8 if it was available. This doesn't work
with XCode 8.3, which will issue a link error. Instead, we now pick up
the llvm-ar from the
llvm-config --bindirdirectory if it isavailable, and otherwise fall back.
As part of this change, the homebrew location for llvm@3.9's llvm-config
is tried if no LLVM_CONFIG is specified.