Fix false positive test failure on 32 bits #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DigestofObject test was failing because of a problem in the `ptr_to_int` helper function. This function was casting a pointer to intptr_t, resulting in an incorrect sign extension. The function now casts to uintptr_t, with the correct behaviour of a zero extension. This doesn't fix any actual correctness issue in Pony programs. Closes ponylang#1747.
Praetonus
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DigestofObject test was failing because of a problem in the
ptr_to_inthelper function. This function was casting a pointer to intptr_t, resulting in an incorrect sign extension. The function now casts to uintptr_t, with the correct behaviour of a zero extension.This doesn't fix any actual correctness issue in Pony programs.
@luigino Could you test an see if it fixes #1747 for you?