Fix compiler assert on arrow to typeparam in constraint. #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes by moving "in constraint" checks for arrow and tupletype from the flatten pass to the syntax pass, so that they are guaranteed to happen before we try to set the cap on the typeparamref. It's also more appropriate to run them there since they are syntax-level checks that require no knowledge of name resolution, or anything else beyond simple syntax frame lookups. Resolves #1694.
jemc
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes by moving "in constraint" checks for arrow and tupletype
from the flatten pass to the syntax pass, so that they are guaranteed
to happen before we try to set the cap on the typeparamref.
It's also more appropriate to run them there since they are syntax-level
checks that require no knowledge of name resolution, or anything else
beyond simple syntax frame lookups.
Resolves #1694.