Build Linux release binaries correctly #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when releasing to bintray, we would run `make deploy arch=x86-64 ... deploy` with the intent of building a pony compiler and runtime that targets the x68-64 instruction set. Unfortunately that isn't what would happen. Because we had previously run `make test-ci` Which doesnt specify an architecture and therefore uses features available on the build machine, we were in fact uploading an arch specific build- the one created by `make test-ci`. With this change, we will remove all `make test-ci` related items and then rebuild for release with the correct make settings. Fixes #1696
SeanTAllen
added
the
triggers release
This was referenced Mar 16, 2017
Closed
SeanTAllen
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when releasing to bintray, we would run
make deploy arch=x86-64 ... deploywith the intent of building a pony compiler and runtime that targets
the x68-64 instruction set. Unfortunately that isn't what would happen.
Because we had previously run
make test-ciWhich doesnt specify an architecture and therefore uses features
available on the build machine, we were in fact uploading an arch
specific build- the one created by
make test-ci.With this change, we will remove all
make test-cirelated items andthen rebuild for release with the correct make settings.
Fixes #1696